Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traypublisher: Actually enable Override Colorspace collector when it should be enabled #639

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Traypublisher: Actually enable Override Colorspace collector when it should be enabled #639

merged 4 commits into from
Jun 17, 2024
+3 −2

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jun 11, 2024

Changelog Description

Fix CollectColorspace plug-in enabled state for tray publisher. Without this change it never shows since enabled is always False.

Additional info

With this fix it shows again and seems to work:
image

Testing notes:

  1. Enable color management
  2. Publish image or plate via traypublisher
  3. The instance should have an "override colorspace" option
  4. The overridden colorspace should work to set the interpreted published colorspace of the file.

@ynbot ynbot added the size/XS label Jun 11, 2024
@ynbot ynbot added host: TrayPublisher type: bug Something isn't working labels Jun 11, 2024
@BigRoy BigRoy added community Issues and PRs coming from the community members size/XS and removed type: bug Something isn't working labels Jun 11, 2024
@iLLiCiTiT
Copy link
Member

Please bump version.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 12, 2024

Please bump version.

Done.

@iLLiCiTiT iLLiCiTiT merged commit 8727cf3 into ynput:develop Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees
No one assigned
Labels
community Issues and PRs coming from the community members host: TrayPublisher size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BigRoy @iLLiCiTiT @ynbot