-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Houdini refactor to generic ExtractROP plug-in #676
Chore: Houdini refactor to generic ExtractROP plug-in #676
Conversation
This is cool! |
… down in the file
I gave it a shot. tested few product types and they worked fine.
|
Lovely! I've never tried the farm submissions. Does it work outside of this PR? (I suppose not?) |
@moonyuet any chance you can also push this through a test-run? |
I try with publishing fbx. Errored out. |
Fixed with 187b2e9 |
Fixed with 32ebf9c - sorry about that. I kept the extractor list next to it and I still missed that it lacked
I have a feeling this issue may exist outside of this PR as well - I don't have Deadline configured on my dev setup currently. Anyone of you able to confirm this quickly using |
I tested with the develop branch, guess the issue of the pointcache is not related to this PR. |
I'd say looking at the tests this should be safe to merge. |
Changelog Description
Improve code re-use and implement a more generic ROP node extractor used by those families for which it applies.
This makes sure that they remain sync in implementation instead of being scattered and helps focusing the implementation on this single plug-in instead simplifying maintenance.
Additional info
This also implements #675 but also generalizes it into a single plug-in instead. (with some subclasses where code deviated)
Fixes #672
Testing notes:
develop