Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadline: provide default user credential fields in studio settings #729

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jul 1, 2024

Changelog Description

Some studios might have only single user/password credentials for communication with Deadline webservice. This PR provides new fields in Studio Settings which could be used as default values. These could be overridden by values provided by artists in Site Settings if necessary.

image

Additional info

AYON secrets cannot be used as artist don't have access to those (and this runs in Tray). I am expecting pushback from customer though.

Testing notes:

  1. enable on Deadline > Tools > Configure Repository Options > Web Service Settings > Require Authentication
  2. set passwor in Deadline > Tools > Manage Users > Webservice password
  3. build and install Deadline addon (remove existing unzipped from AppData)
  4. provide credentials in ayon+settings://deadline/deadline_urls (could be same as from Deadline: webservice password #200 - just delete them first from Site Settings (on Studio page)
  5. publish something to DL, check output from Collect Deadline User Credentials

These values should be used if studio has only single credentials for communicating with Deadline webservice.
These values should be used if studio has only single credentials for communicating with Deadline webservice. Could be overridden by values from Site Settings.
@ynbot
Copy link
Contributor

ynbot commented Jul 1, 2024

@ynbot ynbot added module: Deadline type: enhancement Improvement of existing functionality or minor addition size/XS labels Jul 1, 2024
@kalisp kalisp requested a review from iLLiCiTiT July 2, 2024 13:05
@kalisp kalisp assigned iLLiCiTiT and unassigned LiborBatek Jul 2, 2024
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jul 2, 2024

Artists don't have permissions to read secrets (kinda point of secrets). So they can't access the password value.

Regular artists don't have access to AYON secret, therefore it cannot be used.

Encrypted or at least crossed field for passwords doesn't exist so far.
@kalisp
Copy link
Member Author

kalisp commented Jul 2, 2024

Hmm, was worried about that, so reverted to plain string field.
We need password Setting key and probably fix Since settings are sent to clients, secrets provide a way to hide sensitive data from users. in https://ayon.ynput.io/docs/admin_server_provisioning/#secrets as it points that secrets could be used (but actually cannot, just for use in services).

@kalisp kalisp assigned MilaKudr and LiborBatek and unassigned iLLiCiTiT and MilaKudr Jul 3, 2024
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jul 3, 2024

Well artists don't have access to settings tab. But they can read them... If we would add them access to secrets, it would be the same.

@MilaKudr MilaKudr self-requested a review July 8, 2024 12:04
@kalisp kalisp merged commit ea3c559 into develop Jul 8, 2024
1 check passed
@kalisp kalisp deleted the enhancement/AY-5714_Provide-user-credential-fields-on-Deadline-Studio-Settings branch July 8, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: Deadline size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants