Delete old versions: Add confirm prompt to avoid accidental delete

[BigRoy]

Changelog Description

Add informative confirm prompt for delete versions to avoid accidental clicks deleting versions and files.

Additional info

With "Show details..." clicked:

Testing notes:

1. Open Loader from Tray
2. Use Delete Old Versions action
3. Deletion should be confirmed (and do nothing when cancelled!)

[moonyuet]

When I click on delete old version:
it shows the popup dialog as expected

if I hit Cancel, it won't error out
If I hit Ok, it would keep the latest 45 versions as expected.

I also tested with Calculate Old Version, it also works smoothly without error.

[BigRoy]

@iLLiCiTiT could you provide this a quick glance and merge if you're ok with it?

[iLLiCiTiT]

I would rename Yes to Delete (if possible you can set object name of delete button to #DeleteButton), and moved Show details to most left.

EDITED:
Oh, it's built-in dialog...

[BigRoy]

I would rename Yes to Delete (if possible you can set object name of delete button to #DeleteButton), and moved Show details to most left.

This would 'adhere' to the rules of the current OS - and hence it may look different on Mac OS or Linux if the "Show details" behavior is different there because it's default Qt message box behavior. I'd rather not touch it.

[iLLiCiTiT]

This would 'adhere' to the rules of the current OS - and hence it may look different on Mac OS or Linux if the "Show details" behavior is different there because it's default Qt message box behavior. I'd rather not touch it.

I'm not good at UX, but this doesn't look nice. I had to read the text 2 times to understand what would the buttons do, and was confused why is the biggest button showing details between Yes and Cancel, and still don't understand why it's there (not as a developer but as user).

[BigRoy]

I'm not good at UX, but this doesn't look nice. I had to read the text 2 times to understand what would the buttons do, and was confused why is the biggest button showing details between Yes and Cancel, and still don't understand why it's there (not as a developer but as user).

I see what you mean - yet at the same time - it does allow us to not having to write dedicated widgets and rely on what apparently are more OS native designs for this.

I could also just remove the details information - but I felt since it was now simple using this feature that it's nice 'extra check' someone can do to decide whether it's deleting what they wanted?

@m-u-r-p-h-y from artist perspective? Would you like me to redesign the pop-up dialog? See screenshots in PR description.

Turning this around into a dedicated widget - with maybe a list or items may take me maybe 30m-60m.

[m-u-r-p-h-y]

Delete dialogue is working fine and prevents from accidental deletion of files.

The UI itself needs a lot of love though.

[BigRoy]

Details page is not taking the Remove Publish Folder into account

@m-u-r-p-h-y Would you like the details tab to just report that it's also removing the publish folder - or what kind of output did you expect additionally there?

By the way - I'm fine with merging (so that it's in the client's hands asap) and then polish the UI cosmetics in a follow-up PR.