-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: loader support product type filter profiles #792
Merged
iLLiCiTiT
merged 18 commits into
ynput:develop
from
BigRoy:bugfix/loader_support_product_type_filter_profiles
Jul 26, 2024
Merged
Bugfix: loader support product type filter profiles #792
iLLiCiTiT
merged 18 commits into
ynput:develop
from
BigRoy:bugfix/loader_support_product_type_filter_profiles
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
reviewed
Jul 22, 2024
iLLiCiTiT
reviewed
Jul 22, 2024
iLLiCiTiT
reviewed
Jul 22, 2024
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
reviewed
Jul 22, 2024
iLLiCiTiT
reviewed
Jul 24, 2024
iLLiCiTiT
reviewed
Jul 24, 2024
> Why empty first line? It is like opening book that starts with 2nd chapter 🙂 Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
BigRoy
commented
Jul 25, 2024
BigRoy
commented
Jul 25, 2024
@iLLiCiTiT PR works for me is. Build new addon, configured settings all work great.
✅ 🚀 |
iLLiCiTiT
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Adds back in support for having default Loader product type filters to be specified from settings from
ayon+settings://core/tools/loader/product_type_filter_profiles
Fixes #680
Additional info
Example
With for example a config like
ayon+settings://core/tools/loader/product_type_filter_profiles
:Then for Fusion host by default the loader will have only those product types enabled in the filter.
This provides the artist a much smaller list to look through where maybe most other products they do not care about anyway:
Testing notes:
Update the core addon (so default settings are ok)
ayon+settings://core/tools/loader/product_type_filter_profiles
setting should work in the Loader tool.