Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: loader support product type filter profiles #792

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jul 22, 2024

Changelog Description

Adds back in support for having default Loader product type filters to be specified from settings from ayon+settings://core/tools/loader/product_type_filter_profiles

Fixes #680

Additional info

  • This feature existed in OpenPype, but was missing in AYON since some UI refactoring.
  • Had to remove the default settings value because the default was actually set to for all profiles include nothing. (not sure how this will behave for studios updating?)
  • Updated some available product types in settings that can be set.

Example

With for example a config like ayon+settings://core/tools/loader/product_type_filter_profiles:

image

[
  {
    "hosts": [
      "fusion"
    ],
    "task_types": [],
    "is_include": true,
    "filter_product_types": [
      "render",
      "plate",
      "prerender",
      "image"
    ]
  }
]

Then for Fusion host by default the loader will have only those product types enabled in the filter.
This provides the artist a much smaller list to look through where maybe most other products they do not care about anyway:

image

Testing notes:

Update the core addon (so default settings are ok)

  1. Loader tool should work
  2. Toggling filters on/off manually should behave as expected
  3. The ayon+settings://core/tools/loader/product_type_filter_profiles setting should work in the Loader tool.
  4. The host and task type filtering should work.
  5. By default, without task type filtering set all product types should be shown

@BigRoy BigRoy added the type: bug Something isn't working label Jul 22, 2024
@BigRoy BigRoy requested a review from iLLiCiTiT July 22, 2024 00:13
@ynbot ynbot added the size/XS label Jul 22, 2024
BigRoy and others added 2 commits July 22, 2024 13:34
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@BigRoy BigRoy self-assigned this Jul 22, 2024
@BigRoy BigRoy requested a review from iLLiCiTiT July 22, 2024 12:06
> Why empty first line? It is like opening book that starts with 2nd chapter 🙂

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@BigRoy BigRoy requested a review from iLLiCiTiT July 24, 2024 20:29
@BigRoy
Copy link
Collaborator Author

BigRoy commented Jul 25, 2024

@iLLiCiTiT PR works for me is. Build new addon, configured settings all work great.

  • No profiles: works
  • Allow list profile works
  • Deny list profile works

✅ 🚀
You may need to approve review yourself @iLLiCiTiT and then merge.

@iLLiCiTiT iLLiCiTiT merged commit d45361e into ynput:develop Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loader: Fix support for product_type_filter_profiles
3 participants