Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray: Logout closes tray #838

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Tray: Logout closes tray #838

merged 1 commit into from
Aug 7, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Logout does not keep tray running.

Additional info

The issue was that get_default_settings_variant from ayon_api is actually using global connection, which can't log in if we just logged out.

Testing notes:

  1. Create package, upload to AYON server and use in bundle.
  2. Start AYON tray with console (so you can see if it is closed).
  3. Click on tray icon > Login.
  4. In opened dialog click on Logour and confirm with Ok.
  5. You should be logged out and tray should fully close.

@iLLiCiTiT iLLiCiTiT requested a review from 64qam August 7, 2024 09:37
@ynbot ynbot added size/XS type: bug Something isn't working labels Aug 7, 2024
@iLLiCiTiT iLLiCiTiT merged commit 1e1059e into develop Aug 7, 2024
9 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/logout-fix branch August 7, 2024 11:27
@BigRoy
Copy link
Collaborator

BigRoy commented Aug 7, 2024

Is this really nice UX? Should it restart maybe? I wouldn't expect the app to shutdown when clicking logout, I'd expect a new login prompt. But maybe that's just me?

@iLLiCiTiT
Copy link
Member Author

Is this really nice UX? Should it restart maybe? I wouldn't expect the app to shutdown when clicking logout, I'd expect a new login prompt. But maybe that's just me?

There is option to change login in the UI. The login UI itself deserves better UX, in backlog,

NOTE: This PR did not change the logic, just fixed that there is not phantom tray process if you do use logout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants