Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish report viewer: Don't validate extension of dropped file #840

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Publish report viewer: Don't validate extension of dropped file #840

merged 2 commits into from
Aug 16, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Allow any extension to be dropped into the reports view. If it contains json, it will be loaded.

Testing notes:

  1. Open publish report viewer.
  2. You can drop in .txt file with report.

@ynbot ynbot added the type: enhancement Improvement of existing functionality or minor addition label Aug 8, 2024
@ynbot ynbot added the size/XS label Aug 8, 2024
@iLLiCiTiT iLLiCiTiT removed the size/XS label Aug 8, 2024
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected
image

@iLLiCiTiT iLLiCiTiT merged commit 49b1d0d into develop Aug 16, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/AY-1654_Publish-Report-Viewer-txt-files branch August 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

Assignees

@m-u-r-p-h-y m-u-r-p-h-y

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @m-u-r-p-h-y @ynbot