-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve: avoiding clips without mediapoolitems #92
Resolve: avoiding clips without mediapoolitems #92
Conversation
Asserts creation of media pool item when not found for specified files. This ensures proper handling and error messaging in such cases.
Task linked: OP-8273 Resolve: missing GetClipProperty |
Can we get |
Could you include testing notes?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address some of these questions; #92 (comment)
ClipLoader class in the plugin file now handles LoadError exceptions for creating media pool items when processing files. This change ensures proper error handling during media item creation.
… handling in timeline items retrieval function. - Added a check to skip processing if MediaPoolItem doesn't exist. - Enhanced data handling within the timeline items retrieval function. - this is for case some adjustment clips or fusion clips are on timeline
Thanks to @BigRoy there was found the reason why this error can happen. Thanks man! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets address @BigRoy comments.
those are addressed in #92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully in Resolve 18.6.
For completeness, the error in current develop is this when loading in a clip while having an adjustment clip on the timeline;
During load error happened on Product: "renderCompositingMain" Representation: "exr" Version: 1
Error message: 'NoneType' object has no attribute 'GetClipProperty'
Traceback (most recent call last):
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\tools\loader\models\actions.py", line 763, in _load_representations_by_loader
load_with_repre_context(
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\pipeline\load\utils.py", line 323, in load_with_repre_context
return loader.load(repre_context, name, namespace, options)
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\hosts\resolve\plugins\load\load_clip.py", line 48, in load
timeline_item = plugin.ClipLoader(
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\hosts\resolve\api\plugin.py", line 462, in load
timeline_item = lib.create_timeline_item(
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\hosts\resolve\api\lib.py", line 306, in create_timeline_item
output_timeline_item = get_timeline_item(
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\hosts\resolve\api\lib.py", line 343, in get_timeline_item
_ti_clip_property = _ti_clip.GetMediaPoolItem().GetClipProperty
AttributeError: 'NoneType' object has no attribute 'GetClipProperty'
Changelog Description
When encountering a scenario where resolve timelineitems are not connected to any media pool items, it is possible that these items could be either an Adjustment Clip or a Fusion Composition.
Testing steps
Adjustment Clip
(from effect panel)