generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load filepath to node: Use <UDIM> token #107
Merged
BigRoy
merged 8 commits into
ynput:develop
from
BigRoy:enhancement/AY-6326_load_filepath_udim
Sep 24, 2024
Merged
Load filepath to node: Use <UDIM> token #107
BigRoy
merged 8 commits into
ynput:develop
from
BigRoy:enhancement/AY-6326_load_filepath_udim
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
added
the
type: enhancement
Improvement of existing functionality or minor addition
label
Sep 23, 2024
iLLiCiTiT
reviewed
Sep 23, 2024
moonyuet
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iLLiCiTiT could you do a code review to see if you're ok with the code. It's functional now. :) |
iLLiCiTiT
approved these changes
Sep 24, 2024
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Load UDIM tokens as
<UDIM>
and frame tokens from template as$F{padding}
Additional info
This now uses the formatted template from the representation to define the
frame
andudim
tokens in the full path. Hence, this should technically now also be able to support a filepath with both UDIMs and frames (although I don't think we have anything yet that publishes that)Testing notes:
<UDIM>
token.