Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load filepath to node: Use <UDIM> token #107

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 23, 2024

Changelog Description

Load UDIM tokens as <UDIM> and frame tokens from template as $F{padding}

Additional info

This now uses the formatted template from the representation to define the frame and udim tokens in the full path. Hence, this should technically now also be able to support a filepath with both UDIMs and frames (although I don't think we have anything yet that publishes that)

Testing notes:

  1. Load filepath to node should still work
  2. Published UDIM sequences should load with <UDIM> token.

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Sep 23, 2024
@BigRoy BigRoy self-assigned this Sep 23, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in terms of testing.
image

@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 23, 2024

@iLLiCiTiT could you do a code review to see if you're ok with the code. It's functional now. :)

@iLLiCiTiT
Copy link
Member

Looks good.

@BigRoy BigRoy merged commit aec3535 into ynput:develop Sep 24, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/AY-6326_load_filepath_udim branch September 24, 2024 08:27
@BigRoy BigRoy mentioned this pull request Oct 14, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants