Fix Load Asset LOP and Load Shot LOP (but better?) #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix old LOP loaders missing the file/representation parm expressions due to having explicit attribute value overrides
Additional review information
Before the loaders used explicit parm callbacks to set the filepath and representation id on the nodes. As such, these attributes had "overrides" from their default values - lacking the default expressions. This PR, ensures those parameter expressions are 'reverted' on update.
This will fix through the scene inventory, if e.g. the user broke it actively and then trigger UPDATE once via the loader itself to get the support for changing versions on the nodes directly again.
However, it also fixes existing loaders on scene open.
Testing notes:
Either:
file
orrepresentation
parm expressions.Or:
Then:
The node should be updated.