-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support merged AOVs in arnold render #72
Conversation
Thannks @MustafaJafar and @BigRoy for looking into it. There are parts of the pull request that I don't understand completely. But what we're looking to get is that it shouldn't look for the AOV file paths at all and just integrate the overall file path mentioned in |
It should do that with the current changes as it would now ignore active AOVs that are not explicitly set to be a separate file.
In the comments we're trying to make sure it does both correctly - but the part that allows combined AOVs should already have been solved looking at the code. Anyway, I'll do some testing. |
Thanks @BigRoy for clearing up the misunderstanding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes at least being able render MERGED aovs.
We should follow up with a new issue and PR after this to solve the remaining TODO and the notes given in this comment.
Note that I have not tested whether Cryptomattes break the current "merged" AOV publishing so that remains unconfirmed.
Changelog Description
Fixes #69
Test Runs
Here's a test run on my side.
The setup is shown in the ROP node parameters and the created files are shown in the removed files log.
Testing notes: