generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: local render remove redundant keys and add missing keys #93
Merged
BigRoy
merged 4 commits into
develop
from
bugfix/local-render_fix-frame-start-end-handle
Sep 10, 2024
Merged
Bugfix: local render remove redundant keys and add missing keys #93
BigRoy
merged 4 commits into
develop
from
bugfix/local-render_fix-frame-start-end-handle
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaJafar
added
type: bug
Something isn't working
community
Issues and PRs coming from the community members
labels
Sep 7, 2024
moonyuet
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done a simple test in my side, Looks good.
BigRoy
reviewed
Sep 9, 2024
client/ayon_houdini/plugins/publish/collect_local_render_instances.py
Outdated
Show resolved
Hide resolved
MustafaJafar
changed the title
Bugfix/local render add
Bugfix: local render remove redundant keys and add missing keys
Sep 10, 2024
frameStartHandle
and frameEndHandle
BigRoy
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
resolve #92
it also removes redundant keys
frameStart
andframeEnd
and adds missing keypublish_attributes
.Additional info
This PR just picks few commits from a community PR #77
where community PR tried to fix other problems at the same time that deviated from the problem the PR was trying to fix originally.
Testing notes: