Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old backwards compatibility #118

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

iLLiCiTiT
Copy link
Member

Description

Removed some of backwards compatibility conditions that are not relevant anymore.

Additional information

Some of the conditions were done in reverse > check if major version is 0 major and minor is higher than x and use new code in that case. This is broken when used with new release of AYON server starting with 1, where a backwards compatible code is used.

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves issue when trying to use dev mode with 1.* version of Ayon server.

(400 Client Error: Bad Request for url: http://localhost:5000/api/settings/addons?variant=2023-11-10-01-version_control-dev&site=beige-mackerel-from-ganymede)

@iLLiCiTiT iLLiCiTiT merged commit 43a1480 into develop Dec 13, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/remove-backwards-compatibility branch December 13, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants