Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base CRUD functions for entities #126

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 11, 2024

Description

Added simple CRUD operations for folder, task, product, version and representation.

Resolves #35

status=None,
active=None,
thumbnail_id=None,
folder_id=None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is use case for passing in identifier of an object I want to create? Is that for creation test data/some imports?

Copy link
Member Author

@iLLiCiTiT iLLiCiTiT Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an option in REST api, why not to have it in python api 🙂 . It's heavily used in EntityHub so I can imagine usecase. E.g. recreate project with the same ids?

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question about usefulness of passing ids of created object it looks good.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Mar 15, 2024
@iLLiCiTiT iLLiCiTiT merged commit 494b64c into develop Mar 18, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/CRUD-functions-for-base-entities branch March 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing REST calls to create/update/remove entities
2 participants