-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MD lint
- Loading branch information
Showing
6 changed files
with
114 additions
and
96 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
vendor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"plugins": [ | ||
"remark-preset-lint-consistent", | ||
"remark-preset-lint-recommended" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,37 @@ | ||
# Contributing | ||
|
||
## Getting Started | ||
* Fork, then clone the repo: | ||
```bash | ||
git clone git@github.com:your-username/symfony-jsonrpc-http-server.git | ||
```` | ||
|
||
* Make sure everything goes well: | ||
```bash | ||
make build | ||
make test | ||
``` | ||
|
||
* Make your changes (Add/Update tests according to your changes). | ||
* Make sure tests are still green: | ||
```bash | ||
make test | ||
``` | ||
|
||
* To check code coverage, launch | ||
```bash | ||
make coverage | ||
``` | ||
|
||
* Push to your fork and [submit a pull request](https://github.com/yoanm/symfony-jsonrpc-http-server/compare/). | ||
* Wait for feedback or merge. | ||
|
||
Some stuff that will increase your pull request's acceptance: | ||
* Write tests. | ||
* Follow PSR-2 coding style. | ||
* Write good commit messages. | ||
* Do not rebase or squash your commits when a review has been made. | ||
|
||
* Fork, then clone the repo: | ||
```bash | ||
git clone git@github.com:your-username/symfony-jsonrpc-http-server.git | ||
``` | ||
|
||
* Make sure everything goes well: | ||
```bash | ||
make build | ||
make test | ||
``` | ||
|
||
* Make your changes (Add/Update tests according to your changes). | ||
|
||
* Make sure tests are still green: | ||
```bash | ||
make test | ||
``` | ||
|
||
* To check code coverage, launch | ||
```bash | ||
make coverage | ||
``` | ||
|
||
* Push to your fork and [submit a pull request](https://github.com/yoanm/symfony-jsonrpc-http-server/compare/). | ||
|
||
* Wait for feedback or merge. | ||
|
||
Some stuff that will increase your pull request's acceptance: | ||
* Write tests. | ||
* Follow PSR-2 coding style. | ||
* Write good commit messages. | ||
* Do not rebase or squash your commits when a review has been made. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters