-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timer: timer.unref clears timer #517
Comments
Expected to be re-enabled on yodaos-project/ShadowNode#517 got fixed
Expected to be re-enabled on yodaos-project/ShadowNode#517 got fixed
The current Node.js implementation are very different from ShadowNode(IoT.js) at the However to fix this, I think we should call |
Removed the "good first issue" label just like #558. |
The
timer
should not be cleared but unref-ed in uv-loop. Currently thetimer#unref
is as same as howclearInterval
/clearTimeout
works.The text was updated successfully, but these errors were encountered: