Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code improvements and upgraded to PHP 7.0 #14

Merged
merged 14 commits into from
Jun 23, 2018
Merged

Add code improvements and upgraded to PHP 7.0 #14

merged 14 commits into from
Jun 23, 2018

Conversation

micschwarz
Copy link
Contributor

Made the code more clean, consistent and better to read:

  • Add PHPDoc Comments
  • Split code into smaller functions
  • Add typehints (PHP 7.0 only)
  • Add consistent code style (PSR compliant)

@yohangdev
Copy link
Owner

@micschwarz thank you for your PR. I will deploy & release with major version changes. Please wait.

@yohangdev yohangdev merged commit 320b290 into yohangdev:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micschwarz @yohangdev