Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Simplified Chinese translation README #165

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Conversation

jhcao23
Copy link
Contributor

@jhcao23 jhcao23 commented Apr 14, 2023

  1. add Chinese translation (docs/README-cn.md)
  2. update main readme.md

please approve @yoheinakajima thanks a bunch!

@jhcao23 jhcao23 changed the title add Chinese translation add Chinese translation README Apr 14, 2023
@francip
Copy link
Contributor

francip commented Apr 14, 2023

I apologize, but I am not sure if yours is traditional or simplified. Can you look at #168 which added traditional and figure out if yours should be renamed to simplified and added or not needed?

@jhcao23
Copy link
Contributor Author

jhcao23 commented Apr 14, 2023

@francip 168 is traditional, mine is simplified. but I'll resolve the conflict code first ===> okay ready to Go!

@jhcao23 jhcao23 changed the title add Chinese translation README add Simplified Chinese translation README Apr 14, 2023
@francip francip merged commit f6ee076 into yoheinakajima:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants