Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: ハッシュタグTLをリアルタイムに更新 #144

Merged
merged 2 commits into from
Jul 3, 2024
Merged

frontend: ハッシュタグTLをリアルタイムに更新 #144

merged 2 commits into from
Jul 3, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Jul 3, 2024 •
edited
Loading

close: #128

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.67%. Comparing base (24a2334) to head (f3dfb0b).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
- Coverage    66.18%   64.67%   -1.51%     
===========================================
  Files         1078     1078              
  Lines       132248   132248              
  Branches      5957     4693    -1264     
===========================================
- Hits         87528    85532    -1996     
- Misses       44687    46683    +1996     
  Partials        33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 requested a review from penginn-net July 3, 2024 10:14
penginn-net
penginn-net approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@penginn-net penginn-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kozakura913 kozakura913 merged commit deb5a72 into yojo-art:develop Jul 3, 2024
16 of 21 checks passed
@kozakura913 kozakura913 deleted the hashtag_ws branch July 3, 2024 10:28
@kozakura913 kozakura913 mentioned this pull request Jul 3, 2024
Merged
4 tasks
@kozakura913 kozakura913 self-assigned this Jul 3, 2024
kozakura913 pushed a commit to kozakura913/yojo-art that referenced this pull request Dec 12, 2024
@hideki0403 @chan-mai
feat: 下書き機能 (yojo-art#144)
7ddcfe9 
* add: 下書きに関する関数等の切り離し

* feat: 下書きピッカーを実装

* refactor: indexedDbに移行

* change: uniqueIdの指定を必須に

* fix: マイグレーションが正常に行えない問題を修正

* enhance: 下書きピッカーを改善

* feat: 投稿フォームに下書きを適用できるように

* feat: 下書きを自動保存するかどうかを設定できるように

* feat: 「下書きとして保存」ボタンを実装

* enhance: 既に入力されている内容がある場合に上書き警告を出すように

* add: 翻訳を追加
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penginn-net penginn-net penginn-net approved these changes

Assignees

@kozakura913 kozakura913

Labels
packages/cherrypick-js packages/frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ハッシュタグTLのリアルタイム更新
2 participants
@kozakura913 @penginn-net