Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

サイコロウィジェットを追加 #225

Merged
merged 4 commits into from
Jul 27, 2024
Merged

サイコロウィジェットを追加 #225

merged 4 commits into from
Jul 27, 2024

Conversation

kozakura913
Copy link
Collaborator

持ってきた
1673beta/cherrypick#73

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

kozakura913 and others added 2 commits July 23, 2024 05:57
@kozakura913 @1673beta
feat: サイコロウィジェット
45594e8 
# Conflicts:
#	locales/index.d.ts
#	locales/ja-JP.yml
#	packages/frontend/src/widgets/index.ts

Co-authored-by: Esurio/1673beta <60435625+1673beta@users.noreply.github.com>
@kozakura913
Update CHANGELOG_yojo.md
d3a7c95
@kozakura913 kozakura913 added the ✨enhancement New feature or request label Jul 22, 2024
@kozakura913 kozakura913 requested a review from penginn-net July 22, 2024 21:02
@kozakura913 kozakura913 self-assigned this Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.26%. Comparing base (1dc0d25) to head (cfa3ccd).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #225      +/-   ##
===========================================
- Coverage    81.35%   78.26%   -3.10%     
===========================================
  Files          199      195       -4     
  Lines        34222    29215    -5007     
  Branches       505      474      -31     
===========================================
- Hits         27843    22864    -4979     
+ Misses        6373     6345      -28     
  Partials         6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913
Copy link
Collaborator Author

SPDXの内容、cherrypick-project, esurioは入れるとしてyojo-art team入れる？

@penginn-net
Copy link
Collaborator

追加でなんか入れたなら入れるがいいかも

@kozakura913
Copy link
Collaborator Author

コンフリクト解消しかしてない

@kozakura913
Copy link
Collaborator Author

SPDX yojo-art抜きで、0.3.5リリース後に入れる

@kozakura913 kozakura913 requested a review from penginn-net July 27, 2024 09:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 27, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kozakura913 kozakura913 merged commit 1993118 into yojo-art:develop Jul 27, 2024
14 of 19 checks passed
@kozakura913 kozakura913 deleted the dice-widget branch July 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penginn-net penginn-net penginn-net approved these changes

Assignees

@kozakura913 kozakura913

Labels
✨enhancement New feature or request packages/frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozakura913 @penginn-net