Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance:新着ノート通知があった時まとめるように #387

Merged
merged 8 commits into from
Sep 19, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Aug 29, 2024

What

新着ノート通知があった時まとめるように

Why

Resolve #328
Resolve #108

Additional info (optional)

image

まとめる基準は連続してノート通知があった場合連続してる分をまとめる

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Aug 29, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -46293,6 +46293,7 @@
                         "test",
                         "reaction:grouped",
                         "renote:grouped",
+                        "note:grouped",
                         "pollVote"
                       ]
                     }
@@ -46319,6 +46320,7 @@
                         "test",
                         "reaction:grouped",
                         "renote:grouped",
+                        "note:grouped",
                         "pollVote"
                       ]
                     }

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 7.50000% with 74 lines in your changes missing coverage. Please review.

Project coverage is 40.42%. Comparing base (676dbf7) to head (edb1db6).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...end/src/core/entities/NotificationEntityService.ts 12.50% 21 Missing ⚠️
...rc/server/api/endpoints/i/notifications-grouped.ts 0.00% 18 Missing ⚠️
...ackages/frontend/src/components/MkNotification.vue 0.00% 13 Missing ⚠️
...ckages/frontend/src/components/MkNotifications.vue 0.00% 8 Missing ⚠️
packages/frontend/src/pages/notifications.vue 0.00% 8 Missing ⚠️
packages/backend/src/models/Notification.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #387       +/-   ##
============================================
+ Coverage    20.21%   40.42%   +20.21%     
============================================
  Files          786     1666      +880     
  Lines       117084   224066   +106982     
  Branches      1088     3768     +2680     
============================================
+ Hits         23665    90578    +66913     
- Misses       92831   132844    +40013     
- Partials       588      644       +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net added this to the yojo0.7.0 milestone Aug 29, 2024
@penginn-net
Copy link
Collaborator Author

ノート通知は連続してなくても全部まとめもいい気もする

@penginn-net
Copy link
Collaborator Author

クリックされた時に
新着投稿一覧ページに飛ばすほうがいいかもしれない

通知の新着ノート通知だけ絞り込んで表示する感じ
≠TL

@kozakura913
Copy link
Collaborator

投稿者単位で束ねたい(クリックでユーザーTLに飛ぶ感じで)

@penginn-net
Copy link
Collaborator Author

ユーザーアイコンクリックで飛べばよくないかなとか

@kozakura913 kozakura913 modified the milestones: yojo1.1.0, yojo1.0.0 Aug 30, 2024
@penginn-net penginn-net marked this pull request as draft August 30, 2024 16:45
@penginn-net
Copy link
Collaborator Author

penginn-net commented Sep 1, 2024

kokonectのissueに書いてある方読んでた(書いてあることが違った)
一人一人まとめるより、あっちの方が見やすそうな気がするんだけどどうかしら

@penginn-net
Copy link
Collaborator Author

間に別通知が入るとグループされなくなるのも追いづらいわね

@kozakura913 kozakura913 modified the milestones: yojo1.0.0, yojo1.1.0 Sep 2, 2024
@penginn-net
Copy link
Collaborator Author

image
image

@penginn-net penginn-net marked this pull request as ready for review September 15, 2024 14:50
@penginn-net penginn-net merged commit 64c50d7 into yojo-art:develop Sep 19, 2024
28 of 29 checks passed
@penginn-net penginn-net deleted the new-note-grouping branch September 19, 2024 12:47
@penginn-net penginn-net mentioned this pull request Nov 1, 2024
4 tasks
penginn-net added a commit that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ノート通知を1つにまとめる 投稿通知を通知内の別タブに分離
2 participants