-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance:新着ノート通知があった時まとめるように #387
Conversation
이 PR에 의한 api.json 차이 차이점은 여기에서 볼 수 있음--- base
+++ head
@@ -46293,6 +46293,7 @@
"test",
"reaction:grouped",
"renote:grouped",
+ "note:grouped",
"pollVote"
]
}
@@ -46319,6 +46320,7 @@
"test",
"reaction:grouped",
"renote:grouped",
+ "note:grouped",
"pollVote"
]
} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #387 +/- ##
============================================
+ Coverage 20.21% 40.42% +20.21%
============================================
Files 786 1666 +880
Lines 117084 224066 +106982
Branches 1088 3768 +2680
============================================
+ Hits 23665 90578 +66913
- Misses 92831 132844 +40013
- Partials 588 644 +56 ☔ View full report in Codecov by Sentry. |
ノート通知は連続してなくても全部まとめもいい気もする |
クリックされた時に 通知の新着ノート通知だけ絞り込んで表示する感じ |
投稿者単位で束ねたい(クリックでユーザーTLに飛ぶ感じで) |
ユーザーアイコンクリックで飛べばよくないかなとか |
kokonectのissueに書いてある方読んでた(書いてあることが違った) |
間に別通知が入るとグループされなくなるのも追いづらいわね |
What
新着ノート通知があった時まとめるように
Why
Resolve #328
Resolve #108
Additional info (optional)
まとめる基準は連続してノート通知があった場合連続してる分をまとめる
Checklist