Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(frontend):同じノートを連続してリノートしようとしたときに警告する設定を追加 #409

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Sep 4, 2024

What

同じノートを連続してリノートしようとしたときに警告する設定を追加

Why

Resolve #386

Additional info (optional)

ローカルストレージに保存する、別クライアントとは共有しない
デフォルト無効

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net
Copy link
Collaborator Author

image

image

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 16.98113% with 44 lines in your changes missing coverage. Please review.

Project coverage is 20.21%. Comparing base (676dbf7) to head (2cd3d68).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/get-note-menu.ts 5.00% 19 Missing ⚠️
packages/frontend/src/scripts/check-last-renote.ts 30.76% 18 Missing ⚠️
packages/frontend/src/store.ts 0.00% 4 Missing ⚠️
packages/frontend/src/pages/settings/general.vue 0.00% 2 Missing ⚠️
...rontend/src/pages/settings/preferences-backups.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #409      +/-   ##
===========================================
- Coverage    20.21%   20.21%   -0.01%     
===========================================
  Files          786      787       +1     
  Lines       117084   117133      +49     
  Branches      1088     1088              
===========================================
+ Hits         23665    23674       +9     
- Misses       92831    92871      +40     
  Partials       588      588              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net
Copy link
Collaborator Author

CherryPick => yojo-art
image

@kozakura913 kozakura913 added this to the yojo1.0.0 milestone Sep 4, 2024
@penginn-net penginn-net changed the title Feat:同じノートを連続してリノートしようとしたときに警告する設定を追加 Feat(frontend):同じノートを連続してリノートしようとしたときに警告する設定を追加 Sep 4, 2024
@penginn-net penginn-net merged commit 56eb85f into yojo-art:develop Sep 4, 2024
17 of 18 checks passed
@penginn-net penginn-net deleted the resolve-386 branch September 4, 2024 16:07
@kozakura913 kozakura913 mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

同じノートを連続でRenoteしようとしたときに警告する機能
2 participants