Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(frontend):翻訳が成功しても翻訳中のままになる問題を修正 #415

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Sep 5, 2024

What

Fix(frontend):翻訳を利用できるときに翻訳中のままになる問題を修正
#407 でのやらかしを修正
修正漏れも

Why

Fix #414

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net penginn-net changed the title Fix(frontend):翻訳を利用できるときに翻訳中のままになる問題を修正 Fix(frontend):翻訳が成功しても翻訳中のままになる問題を修正 Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 20.21%. Comparing base (3d6f2e5) to head (fda625d).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/get-note-menu.ts 0.00% 8 Missing ⚠️
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 1 Missing ⚠️
packages/frontend/src/pages/user/home.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #415       +/-   ##
============================================
- Coverage    40.45%   20.21%   -20.25%     
============================================
  Files         1664      787      -877     
  Lines       223633   117145   -106488     
  Branches      3819     1088     -2731     
============================================
- Hits         90462    23676    -66786     
+ Misses      132526    92881    -39645     
+ Partials       645      588       -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net
Copy link
Collaborator Author

キャッチしたらreturnしたほうがいい?

@penginn-net penginn-net merged commit 7531403 into yojo-art:develop Sep 5, 2024
16 of 17 checks passed
@kozakura913 kozakura913 mentioned this pull request Sep 5, 2024
@penginn-net penginn-net deleted the 414 branch December 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

翻訳機能が使える場合でも表示できない
2 participants