Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リバーシ連合v1.1.0 #569

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kozakura913
Copy link
Collaborator

What

対戦中リアクション送信/受信を追加

Why

対戦中にリアクションを送る機能が追加されたので

Additional info (optional)

動作未確認

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Dec 13, 2024

이 PR에 의한 api.json 차이
차이점이 없습니다.
Get diff files from Workflow Page

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 5.17241% with 55 lines in your changes missing coverage. Please review.

Project coverage is 38.46%. Comparing base (869c8cf) to head (e89a11c).

Files with missing lines Patch % Lines
.../backend/src/core/activitypub/ApRendererService.ts 4.76% 20 Missing ⚠️
packages/backend/src/core/ReversiService.ts 0.00% 14 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 0.00% 14 Missing ⚠️
...ckend/src/core/activitypub/models/ApGameService.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #569       +/-   ##
============================================
+ Coverage    19.88%   38.46%   +18.58%     
============================================
  Files          797     1692      +895     
  Lines       122905   229546   +106641     
  Branches      1041     3864     +2823     
============================================
+ Hits         24439    88302    +63863     
- Misses       97861   140579    +42718     
- Partials       605      665       +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 self-assigned this Dec 13, 2024
@kozakura913 kozakura913 added this to the yojo1.3.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant