Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザー詳細「サーバー情報」の重複を修正 #571

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

kozakura913
Copy link
Collaborator

What

ユーザー詳細の「サーバー情報」が重複してたのを片方削除

Why

独自追加してたけどcherrypick側でも追加されて重複した

Additional info (optional)

cherrypick側の実装を残した

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.88%. Comparing base (869c8cf) to head (739e43b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #571   +/-   ##
========================================
  Coverage    19.88%   19.88%           
========================================
  Files          797      797           
  Lines       122905   122897    -8     
  Branches      1041     1041           
========================================
  Hits         24439    24439           
+ Misses       97861    97853    -8     
  Partials       605      605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 merged commit 4545019 into yojo-art:develop Dec 17, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants