Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFMの検索エンジンをユーザー設定で変える #575

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kozakura913
Copy link
Collaborator

What

MFMの検索エンジンをユーザー設定>プライバシーで変えられるように

Why

resolve: #515

Additional info (optional)

初期値はインスタンス内検索に変更してある

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 added this to the 1.3.0 milestone Dec 19, 2024
@kozakura913 kozakura913 self-assigned this Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 19.88%. Comparing base (4545019) to head (6961de7).

Files with missing lines Patch % Lines
packages/frontend/src/pages/settings/privacy.vue 0.00% 7 Missing ⚠️
packages/frontend/src/store.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #575      +/-   ##
===========================================
+ Coverage    19.65%   19.88%   +0.23%     
===========================================
  Files          797      797              
  Lines       122897   122917      +20     
  Branches      1043     1041       -2     
===========================================
+ Hits         24152    24448     +296     
+ Misses       98138    97864     -274     
+ Partials       607      605       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net
Copy link
Collaborator

・デフォルトGoogleでいいような気もするような
・ドロップダウンリストで何個か入れておいて手動でもできるとかがよさげ?(元デフォルトのGoogleに変えるときにわざわざ調べるが発生しそうだし)
・プライバシーよりも全般→動作な気がする
・設定多分バックアップされない

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFM検索窓機能で検索エンジンを選べるようにする
2 participants