Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: すべてのノートに翻訳ボタンが表示される/本文がなくて投票だけあると翻訳が表示されなくなる #579

Merged
merged 9 commits into from
Dec 21, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Dec 20, 2024

What

翻訳判定の変更
本文がなくて投票だけあると翻訳が表示されなくなるのも修正

Why

すべてのノートに翻訳ボタンが表示される

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net
Copy link
Collaborator Author

penginn-net commented Dec 20, 2024

ノート本文のボタンだけで投票も翻訳したいわね
変えた

@kozakura913 kozakura913 added this to the 1.2.1 milestone Dec 20, 2024
@penginn-net penginn-net marked this pull request as ready for review December 21, 2024 04:12
@penginn-net penginn-net self-assigned this Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 19.88%. Comparing base (81106eb) to head (fd7b415).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #579       +/-   ##
============================================
- Coverage    38.48%   19.88%   -18.61%     
============================================
  Files         1692      797      -895     
  Lines       229592   123006   -106586     
  Branches      3877     1041     -2836     
============================================
- Hits         88354    24457    -63897     
+ Misses      140613    97944    -42669     
+ Partials       625      605       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net changed the title Fix: すべてのノートに翻訳ボタンが表示される Fix: すべてのノートに翻訳ボタンが表示される/本文がなくて投票だけあると翻訳が表示されなくなる Dec 21, 2024
@penginn-net penginn-net merged commit d35522e into yojo-art:develop Dec 21, 2024
21 of 22 checks passed
@penginn-net penginn-net deleted the fix-note-translate branch December 21, 2024 06:37
@kozakura913 kozakura913 mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants