Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

タイムラインオプションで表示有無選択の選択肢を修正 #590

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Dec 22, 2024

What

タイムラインオプションで表示切り替えするタブ選択肢からチャンネルを削除し、タグを追加
image

Why

ユーザー設定画面と統一、存在しない項目を修正

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 added this to the 1.2.2 milestone Dec 22, 2024
@kozakura913 kozakura913 self-assigned this Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 19.86%. Comparing base (034a45e) to head (8921706).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/timeline.vue 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    19.86%   19.86%           
========================================
  Files          797      797           
  Lines       123092   123092           
  Branches      1041     1041           
========================================
  Hits         24457    24457           
  Misses       98030    98030           
  Partials       605      605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 merged commit 7f72cf9 into yojo-art:develop Dec 23, 2024
9 of 10 checks passed
@kozakura913 kozakura913 mentioned this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants