Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

更新チェックでCherrypickの更新情報見てた箇所を修正 #599

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Dec 26, 2024

What

更新チェックでCherrypickの更新情報見てた箇所を修正

Why

#565 の変更漏れ

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 19.87%. Comparing base (0acc86a) to head (6e70d8c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/index.vue 0.00% 4 Missing ⚠️
...ges/frontend/src/ui/_common_/navbar-for-mobile.vue 0.00% 4 Missing ⚠️
packages/frontend/src/ui/_common_/navbar.vue 0.00% 4 Missing ⚠️
packages/frontend/src/ui/classic.header.vue 0.00% 4 Missing ⚠️
packages/frontend/src/ui/classic.sidebar.vue 0.00% 4 Missing ⚠️
...ges/frontend/src/ui/friendly/navbar-for-mobile.vue 0.00% 4 Missing ⚠️
packages/frontend/src/ui/friendly/navbar.vue 0.00% 4 Missing ⚠️
packages/frontend/src/boot/common.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #599       +/-   ##
============================================
- Coverage    38.45%   19.87%   -18.58%     
============================================
  Files         1692      797      -895     
  Lines       229720   123108   -106612     
  Branches      3864     1041     -2823     
============================================
- Hits         88340    24473    -63867     
+ Misses      140755    98030    -42725     
+ Partials       625      605       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 marked this pull request as ready for review December 26, 2024 11:04
@kozakura913 kozakura913 self-assigned this Dec 26, 2024
@kozakura913 kozakura913 added this to the 1.2.2 milestone Dec 26, 2024
@kozakura913 kozakura913 changed the title repos/yojo-art/cherrypick 更新チェックでCherrypickの更新情報見てた箇所を修正 Dec 26, 2024
@kozakura913 kozakura913 merged commit 5bce17b into yojo-art:develop Dec 26, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants