Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): ノートとユーザーの検索時に照会を行うかを選択できるように #89

Merged
merged 12 commits into from
Jun 20, 2024

Conversation

penginn-net
Copy link
Collaborator

What

ノートとユーザーの検索時に照会を行うかが選択できるように
@foo@example.com形式でユーザ検索した場合に照会ができるように

Why

Resolve #50
検索の利便性向上
image
image

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

Copy link

sonarqubecloud bot commented Jun 8, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

locales/en-US.yml Outdated Show resolved Hide resolved
packages/frontend/src/pages/search.note.vue Outdated Show resolved Hide resolved
packages/frontend/src/pages/search.user.vue Outdated Show resolved Hide resolved
packages/frontend/src/pages/search.user.vue Outdated Show resolved Hide resolved
packages/frontend/src/pages/search.user.vue Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (25de0c6) to head (b133f7b).
Report is 1 commits behind head on develop.

Current head b133f7b differs from pull request most recent head 86ec710

Please upload reports for the commit 86ec710 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #89       +/-   ##
============================================
+ Coverage    59.58%   77.65%   +18.06%     
============================================
  Files          854      194      -660     
  Lines        98682    28861    -69821     
  Branches      5321      495     -4826     
============================================
- Hits         58801    22412    -36389     
+ Misses       39852     6442    -33410     
+ Partials        29        7       -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net requested a review from kozakura913 June 19, 2024 22:18
@penginn-net penginn-net marked this pull request as draft June 19, 2024 22:53
@penginn-net penginn-net marked this pull request as ready for review June 20, 2024 11:55
Copy link
Collaborator

@kozakura913 kozakura913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ロケール良さそう

@penginn-net penginn-net merged commit 39b596f into yojo-art:develop Jun 20, 2024
10 of 16 checks passed
@penginn-net penginn-net deleted the re-i50 branch June 21, 2024 17:56
@penginn-net penginn-net added this to the Release-1 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL検索時に照会を書けるかどうかのポップアップを出す
2 participants