Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for sticky search header #1188

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Jul 9, 2024

This seems to be causing more trouble than good and breaks some use cases we were unaware of so I'm making it false by default.

Also renaming Window to Search Window in settings. Window is way too vague and I think users would have trouble finding the settings here or understanding what they do.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Jul 9, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner July 9, 2024 14:26
@Kuuuube Kuuuube added this pull request to the merge queue Jul 9, 2024
Merged via the queue into yomidevs:master with commit 156ceba Jul 9, 2024
10 of 11 checks passed
@Kuuuube Kuuuube deleted the sticky-search-header-option branch July 9, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants