Sort dictionary entries by number of text processors applied #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1200 will not alter performanceComparing Summary
|
|
Okay, I believe that the issue should be fixed, and everything should be sound. I will leave this as draft for some more so we can test things more thoroughly though. |
|
Tested on Japanese. |
StefanVukovic99
added
kind/bug
Co-authored-by: Stefan Vuković <stefanvukovic44@gmail.com> Signed-off-by: Cashew <52880648+cashewnuttynuts@users.noreply.github.com>
…-tan into sort-by-variants
StefanVukovic99
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1060 .
This PR adds a
textProcessorRuleChainCandidatesobject similar toinflectionRuleChainCandidatesso that it is easier to trace the textProcessor rules applied and sort based on that number.For example, after this PR, (using CC100 frequency-based sorting) おっと should correctly match 夫 before 音, and へった should correctly match 減る before 下手。