Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "Search text with non-Japanese characters" when language is not Japanese #1247

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Hide "Search text with non-Japanese characters" when language is not Japanese #1247

merged 1 commit into from
Jul 20, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Jul 20, 2024

Also clarifies that it only applies to japanese when japanese is selected.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Jul 20, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner July 20, 2024 03:32
@github-actions GitHub Actions
Copy link

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@Casheeew Casheeew added this pull request to the merge queue Jul 20, 2024
Merged via the queue into yomidevs:master with commit 77b184a Jul 20, 2024
11 checks passed
@lindseycadwell lindseycadwell mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Casheeew Casheeew Casheeew approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuuuube @Casheeew