Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Correct Korean deinflection rules #1266

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

Casheeew
Copy link
Member

@Casheeew Casheeew commented Jul 24, 2024

This PR fixes the following issues:

  1. The 아/어 form of 이다 is 이어 or 여, this is not reflected correctly in the deinflection rules (it stays the same) (e.g 여서, 이어서 is not deinflected to postpositional particle ida )
    See the wiktionary entry for ida for more info
  2. Existing rule -아/어지이다 might be a typo of the -아/어지다 rule. I cannot seem to find any instance of -아/어지이다 on the Internet. -아/어지이다 seems to be an entry in STDict, adding -아/어지다 rule however as it is a common grammatical structure
  3. Existing rule -아/아서 is a typo of -아/어서, should be -아/어서
  4. The rules for -야 is in regular Korean and not in jamo

This PR also adds tests for those cases.

@Casheeew Casheeew requested a review from a team as a code owner July 24, 2024 13:29
@Casheeew Casheeew changed the title Correct Korean deinflection rules [ko] Correct Korean deinflection rules Jul 24, 2024
@Casheeew
Copy link
Member Author

@Lyroxide please review :nanabeg:

@Lyroxide
Copy link

looks good

@jamesmaa jamesmaa added this pull request to the merge queue Jul 25, 2024
Merged via the queue into yomidevs:master with commit 4a93130 Jul 25, 2024
10 checks passed
@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/linguistics The issue or PR is related to linguistics labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants