Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Add short causative form #1366

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

khaitruong922
Copy link

https://gohoneko.neocities.org/grammar/taekim#149%20Causative%20Verbs
https://www.tofugu.com/japanese-grammar/verb-causative-form-saseru/

Screenshot 2024-08-28 at 14 41 30

The only problem is that this rule is currently polluting させられる form with 2 possible conjugations. The shortened causative form is never combined with the second way. Is there any way to handle this exception? If not then let's consider if it's worth to add this form.

@khaitruong922 khaitruong922 requested a review from a team as a code owner August 28, 2024 07:45
Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #1366 will not alter performance

Comparing khaitruong922:shortened-causative-form (92db6c1) with master (8509bcb)

Summary

✅ 3 untouched benchmarks

🆕 2 new benchmarks
⁉️ 2 (👁 2) dropped benchmarks

Benchmarks breakdown

Benchmark master khaitruong922:shortened-causative-form Change
👁 japanese transformations (n=61) 16.1 ms N/A N/A
🆕 japanese transformations (n=63) N/A 15.5 ms N/A
👁 japanese transformations-full (n=166) 36.2 ms N/A N/A
🆕 japanese transformations-full (n=172) N/A 38.7 ms N/A

@khaitruong922 khaitruong922 marked this pull request as draft August 28, 2024 07:47
@khaitruong922 khaitruong922 marked this pull request as ready for review August 29, 2024 08:16
@khaitruong922 khaitruong922 changed the title [ja] Add shortened causative form [ja] Add short causative form Aug 29, 2024
@khaitruong922
Copy link
Author

khaitruong922 commented Aug 29, 2024

Ready for review.

Added v5s for short causative form, which can conjugates to all v5 forms (including -masu), excluding potential form.

食べさせられる will only resolves to causative >> potential or passive, not short causative >> potential >> potential or passive anymore.

@jamesmaa jamesmaa added this pull request to the merge queue Aug 29, 2024
Merged via the queue into yomidevs:master with commit a995d52 Aug 29, 2024
11 checks passed
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants