Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] add ~ておく conjugation #1399

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

khaitruong922
Copy link

  • Add -teoku conjugation (similar to -teiru works)
  • Remove -toku conjugation and move its rules to -teoku.
  • Add ないでおく, ないどく

@khaitruong922 khaitruong922 requested a review from a team as a code owner September 8, 2024 04:17
Copy link

codspeed-hq bot commented Sep 8, 2024

CodSpeed Performance Report

Merging #1399 will not alter performance

Comparing khaitruong922:teoku (2a30118) with master (aaa1617)

Summary

✅ 3 untouched benchmarks

🆕 2 new benchmarks
⁉️ 2 (👁 2) dropped benchmarks

Benchmarks breakdown

Benchmark master khaitruong922:teoku Change
👁 japanese transformations (n=72) 18.5 ms N/A N/A
🆕 japanese transformations (n=76) N/A 23 ms N/A
👁 japanese transformations-full (n=197) 45.5 ms N/A N/A
🆕 japanese transformations-full (n=207) N/A 48.3 ms N/A

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Sep 9, 2024
@jamesmaa jamesmaa added this pull request to the merge queue Sep 9, 2024
Merged via the queue into yomidevs:master with commit 5ebe212 Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants