Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cantonese, Mandarin, JPDB Recommended Dictionaries #1430

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Sep 18, 2024

The JPDB owner gave permission to use the JPDB dictionary as long as the site is linked.

@MarvNC MarvNC requested a review from a team as a code owner September 18, 2024 00:40
@MarvNC MarvNC changed the title Add Cantonese and Mandarin Recommended Dictionaries Add Cantonese, Mandarin, Wikipedia Recommended Dictionaries Sep 18, 2024
@MarvNC MarvNC changed the title Add Cantonese, Mandarin, Wikipedia Recommended Dictionaries Add Cantonese, Mandarin, JPDB Recommended Dictionaries Sep 18, 2024
ext/data/recommended-dictionaries.json Outdated Show resolved Hide resolved
@jamesmaa jamesmaa added this pull request to the merge queue Sep 18, 2024
Merged via the queue into yomidevs:master with commit 833ec58 Sep 18, 2024
12 checks passed
@MarvNC MarvNC deleted the add-recommended-dicts branch September 18, 2024 21:16
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants