Edit vertical-align style for structured content hyperlinks
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
approved these changes
Oct 22, 2023
djahandarie
added
kind/meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: vertical-align style on structured content hyperlinks causes visual glitches
I'll preface this by saying I haven't actually used Yomitan. I've only tested this in the final version of Yomichan (published Oct 23 2022) and the latest version of Yomibaba. Presumably they behave identically.
I produced a sample dictionary.zip with a few entries to test this style change. The relevant entry is under the word
リンク. Images are below.Links in Chromium with 'vertical-align' set to 'middle'
Links in Chromium with 'vertical-align' set to 'baseline'
For whatever reason, Firefox doesn't display much of a difference. It seems that its rendering engine must handle
vertical-alignstyles differently. I assume this is why toasted-nutbread didn't catch the problem.Links in Firefox with 'vertical-align' set to 'middle'
Links in Firefox with 'vertical-align' set to 'baseline'