Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of sentence-furigana needs to not be escaped. With the new handlebars changes this requires using
{{{ }}}
syntax. https://handlebarsjs.com/guide/expressions.html#html-escapingAs far as I can tell this is the only handlebar with this issue but I haven't thoroughly tested every single one.
I also had to make a small change to the version 25 update or
npm run "test:unit:options"
test would fail due to one out of three profiles havingprofile.options.input
set to undefined. (does anyone run this test when making changes?)