Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentence-furigana template #733

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Feb 27, 2024

The output of sentence-furigana needs to not be escaped. With the new handlebars changes this requires using {{{ }}} syntax. https://handlebarsjs.com/guide/expressions.html#html-escaping

As far as I can tell this is the only handlebar with this issue but I haven't thoroughly tested every single one.

I also had to make a small change to the version 25 update or npm run "test:unit:options" test would fail due to one out of three profiles having profile.options.input set to undefined. (does anyone run this test when making changes?)

@Kuuuube Kuuuube requested a review from a team as a code owner February 27, 2024 20:48
Copy link

codspeed-hq bot commented Feb 27, 2024

CodSpeed Performance Report

Merging #733 will improve performances by 47.13%

Comparing Kuuuube:sentence-furigana-fix (7f88b7f) with master (e47a0f4)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark master Kuuuube:sentence-furigana-fix Change
transformations (n=57) 54.7 ms 37.2 ms +47.13%

Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@Casheeew Casheeew added the kind/bug The issue or PR is regarding a bug label Feb 27, 2024
@djahandarie
Copy link
Collaborator

I also had to make a small change to the version 25 update or npm run "test:unit:options" test would fail due to one out of three profiles having profile.options.input set to undefined. (does anyone run this test when making changes?)

@toasted-nutbread Should we add this to CI?

@djahandarie djahandarie added this pull request to the merge queue Mar 2, 2024
Merged via the queue into yomidevs:master with commit 9577449 Mar 2, 2024
10 checks passed
@toasted-nutbread toasted-nutbread mentioned this pull request Mar 2, 2024
@Casheeew Casheeew added the area/anki The issue or PR is related to Anki integration label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/anki The issue or PR is related to Anki integration kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants