Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated title #735

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Conversation

Casheeew
Copy link
Member

fixes #709
fixes #526

@Casheeew Casheeew requested a review from a team as a code owner February 28, 2024 09:06
@Casheeew Casheeew added the kind/bug The issue or PR is regarding a bug label Feb 28, 2024
Copy link

github-actions bot commented Feb 28, 2024

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@toasted-nutbread
Copy link

Honestly it may be better to fix this by just changing the implementation of _getBrowserIconTitle to read from the manifest action.default_title. (Making sure this works on Firefox of course.)

Right now, this change makes the assumption that the title is in the format " - status", which is mostly correct, but is not an assumption that needs to be made.

djahandarie
djahandarie previously approved these changes Mar 3, 2024
Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Scrub1492 LGTM but needs conflict resolution 🙏

@Casheeew Casheeew added the area/ui-ux The issue or PR is related to UI/UX/Design label Mar 4, 2024
@djahandarie
Copy link
Collaborator

@Scrub1492 Ping ^ Needs conflict resolution to merge

@jamesmaa jamesmaa added this pull request to the merge queue Apr 9, 2024
Merged via the queue into yomidevs:master with commit 11e58d6 Apr 9, 2024
10 checks passed
Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #735 will not alter performance

Comparing Scrub1492:fix-duplicated-title (17a2929) with master (2c5af21)

Summary

✅ 3 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug
Projects
None yet
5 participants