Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint unsafe rule #887

Merged
merged 10 commits into from
May 9, 2024
Merged

Update eslint unsafe rule #887

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d9ca72
Enable @typescript-eslint/no-unsafe-assignment
toasted-nutbread Feb 25, 2024
5849873
Updates
toasted-nutbread Feb 25, 2024
b6bacae
Add missing import
toasted-nutbread Mar 2, 2024
d69ce2c
Updates
toasted-nutbread Mar 3, 2024
bc1eae6
Fix types?
jamesmaa May 7, 2024
a853416
Fix tests
jamesmaa May 7, 2024
5896a50
Address comments
jamesmaa May 8, 2024
489ec4e
Move TextProcessorVariant to types
jamesmaa May 8, 2024
a7530e1
Merge branch 'master' into jmaa/update-eslint-unsafe
jamesmaa May 8, 2024
a293d2c
Update types/ext/translation-internal.d.ts
jamesmaa May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ext/js/language/translator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ export class Translator {
/** @type {import('translation-internal').DatabaseDeinflection[]} */
const deinflections = [];
const used = new Set();
/** @type {Map<string, Map<string, Map<string, string>>>} */
/** @type {Map<string, Map<any, Map<any, string>>>} */
StefanVukovic99 marked this conversation as resolved.
Show resolved Hide resolved
const sourceCache = new Map(); // For reusing text processors' outputs

for (
Expand Down Expand Up @@ -502,12 +502,12 @@ export class Translator {
* @param {import('language').TextProcessorWithId<unknown>[]} textProcessors
* @param {Map<string, unknown>} processorVariant
* @param {string} text
* @param {Map<string, Map<string, Map<string, string>>>} textCache
* @param {Map<string, Map<any, Map<any, string>>>} textCache
* @returns {string}
*/
_applyTextProcessors(textProcessors, processorVariant, text, textCache) {
for (const {id, textProcessor: {process}} of textProcessors) {
const setting = String(processorVariant.get(id));
const setting = processorVariant.get(id);

let level1 = textCache.get(text);
if (!level1) {
Expand Down