Don't add unnecessary headers build phase #118
Conversation
|
Thanks @ryohey! |
| addObject(headersBuildPhase) | ||
| buildPhases.append(headersBuildPhase.reference) | ||
| if target.type == .framework || target.type == .dynamicLibrary { | ||
| let headersBuildPhase = PBXHeadersBuildPhase(reference: generateUUID(PBXHeadersBuildPhase.self, target.name), files: getBuildFilesForPhase(.headers)) |
There was a problem hiding this comment.
Should we also only create this if getBuildFilesForPhase here returns a non-empty array?
There was a problem hiding this comment.
Yes, this check could be added though the same would apply to the sources and resources build phase. I had it like this originally incase people wanted to easily add files to these build phases in Xcode (that's assuming they are only generating once and then checking in the project file)
In either case it's not something we have to cover in this PR
There was a problem hiding this comment.
Ah makes sense, I guess for some of these it's just preference, since in our all swift project we'll never need this build phase.
There was a problem hiding this comment.
Yeah, I think the empty ones could be removed
|
One thought, but looks good to me! |
I found that header files are unwantedly copied into the application package.
I checked that only the dynamicLibrary and the framework contained headers from the newly created project from the template.