Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for visionOS #1379

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Conversation

shiba1014
Copy link
Contributor

@shiba1014 shiba1014 commented Jul 28, 2023

This PR adds a support for visionOS. Resolves #1369.

  • Add support for visionOS
  • Update documents

You can create visionOS project by following yml:

name: MyProject
targets:
  MyApp:
    type: application
    platform: visionOS
    deploymentTarget: "1.0"
    sources: [MyApp]
    settings:
      base:
        PRODUCT_BUNDLE_IDENTIFIER: "$(APP_IDENTIFIER).VisionApp"

Copy link
Collaborator

@freddi-kit freddi-kit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sources/XcodeGenKit/CarthageDependencyResolver.swift Outdated Show resolved Hide resolved
@shiba1014 shiba1014 marked this pull request as ready for review August 1, 2023 02:10
Docs/ProjectSpec.md Outdated Show resolved Hide resolved
@freddi-kit
Copy link
Collaborator

Please update https://github.com/yonaskolb/XcodeGen/blob/master/CHANGELOG.md

@freddi-kit freddi-kit self-requested a review August 1, 2023 02:27
Copy link
Collaborator

@freddi-kit freddi-kit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job

@Dahlgren
Copy link
Contributor

Dahlgren commented Aug 2, 2023

The SettingsPresets for visionOS are missing which is causing this warning to be printed: No "visionOS" settings found

There needs to be a visionOS.yml in SettingPresets/Platforms or the the Xcode target will fallback to macOS SDK

SDKROOT: xros
TARGETED_DEVICE_FAMILY: 7

https://github.com/yonaskolb/XcodeGen/tree/master/SettingPresets/Platforms

Likely application_visionOS.yml will also be required in SettingPresets/Product_Platform with icon settings
https://github.com/yonaskolb/XcodeGen/tree/master/SettingPresets/Product_Platform

@shiba1014
Copy link
Contributor Author

@Dahlgren Thank you, I fixed it: 24ae6c6

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @shiba1014!

@yonaskolb yonaskolb merged commit 3a215ce into yonaskolb:master Aug 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Support for Apple Vision Pro platform?
5 participants