-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watchOS as a supported destination #1438
Add watchOS as a supported destination #1438
Conversation
case .watchOS: | ||
return 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yonaskolb and @amatig,
I'm wondering why the priorities are currently in this order and where watchOS
should be. Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding test cases helped me realize this - TARGETED_DEVICE_FAMILY
and SUPPORTED_PLATFORMS
are ordered based on this priority. watchOS is 4
, meaning it needs to be between tvOS (3
) and visionOS (7
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution! I wished this feature 💯
I'll test this feature for my use case.
@@ -484,7 +484,33 @@ class ProjectGeneratorTests: XCTestCase { | |||
try expect(targetConfig1.buildSettings["ASSETCATALOG_COMPILER_APPICON_NAME"] as? String) == "AppIcon" | |||
try expect(targetConfig1.buildSettings["CODE_SIGN_IDENTITY"] as? String) == "iPhone Developer" | |||
} | |||
|
|||
|
|||
$0.it("supportedDestinations merges settings - iOS, watchOS") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests can be parameterized tests to reduce redundancy.
But it's better existing test cases also become parameterized tests.
So I think it's good at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tatsuky
Hi, I'm new to this project. This PR adds the watchOS support for the
supportedDestinations
configuration, initially added in #1336.Changes
watchOS
case to theSupportedDestination
enum.Tests
You can use the following example spec to verify the changes.
Thanks.