Add implicit option to framework Dependency #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbarow
changed the title
yonaskolb
reviewed
Nov 21, 2017
Sources/ProjectSpec/Dependency.swift
Outdated
| @@ -17,12 +17,14 @@ public struct Dependency: Equatable { | |||
| public var codeSign: Bool = true | |||
| public var removeHeaders: Bool = true | |||
| public var link: Bool = true | |||
| public var implicit: Bool? | |||
There was a problem hiding this comment.
As a nil value has no real meaning here we can make it default to false. Something like embed is an optional as the default changes depending on other factors
Docs/ProjectSpec.md
Outdated
|
|
||
| This only applies to `framework` dependencies. | ||
|
|
||
| - ⚪️ **implicit**: `Bool` - Whether the framework is an implicit dependency. This can be useful in a Workspace where projects are not nested within each other. |
There was a problem hiding this comment.
We can mention that the default is false, and also how this works - that the framework will look in the build products directory
|
Great, updated. Let me know if the docs section makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #165 - I didn't have coffee before trying to rebase this morning 😞
Fixes: #163