Allow missing files in sources #200
Conversation
|
Yeah I thought someone might bring up the strictness of the file validation eventually :) |
|
We are pointing directly to file, like so: sources:
- path: Assets.generated.swift
type: file
optional: true
- path: GraphQL.generated.swift
type: file
optional: trueI kind of like to have this missing source check enables for other files as this kind of missing file inclusion is exception. |
| @@ -101,6 +101,16 @@ func projectSpecTests() { | |||
| try expectValidationError(spec, .invalidSchemeConfig(scheme: "scheme1", config: "debugInvalid")) | |||
| try expectValidationError(spec, .invalidSchemeConfig(scheme: "scheme1", config: "releaseInvalid")) | |||
| } | |||
|
|
|||
| $0.it("allows missing optional file", closure: { | |||
There was a problem hiding this comment.
nitpick: we use trailing closure for these 👍
Thanks for the test! :)
There was a problem hiding this comment.
Uniform style is important. Changed it.
|
Ok great, some good reasons there 👍 |
Adds `optional` flag to `TargetSource` to allow files that do not exist yet. This is useful in cases where build script will generate files.
alvarhansen
force-pushed
the
optional-file
branch
from
6c8e980
to
24c8668
Compare
|
Here's a small bug related to this change #210 |
Adds
optionalflag toTargetSourceto allow files that do not exist yet.This is useful in cases where build script will generate files.