Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying a topic when subscribing to a document #105

Merged
merged 8 commits into from
Jun 19, 2023
Merged

Allow specifying a topic when subscribing to a document #105

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
67ce2ee
add OperationInfo classes
7hong13 Jun 13, 2023
7ff2e7b
implement document subscription with the specific target path
7hong13 Jun 15, 2023
6380254
add instrumentation tests on document subscription
7hong13 Jun 15, 2023
a277130
format fixed
7hong13 Jun 15, 2023
c88a30a
remove wildcard
7hong13 Jun 15, 2023
fb32177
Fix PresenceInfo inconsistency and test failures (#106)
7hong13 Jun 19, 2023
68602fb
adjust timeout limit
7hong13 Jun 19, 2023
8de3704
remove targetEventStreams and make events() return Flow
7hong13 Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions yorkie/src/androidTest/kotlin/dev/yorkie/core/ClientTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ import dev.yorkie.document.Document
import dev.yorkie.document.Document.Event.LocalChange
import dev.yorkie.document.Document.Event.RemoteChange
import dev.yorkie.document.change.CheckPoint
import dev.yorkie.document.crdt.CrdtPrimitive
import dev.yorkie.document.json.JsonCounter
import dev.yorkie.document.json.JsonPrimitive
import dev.yorkie.document.operation.RemoveOperation
import dev.yorkie.document.operation.SetOperation
import dev.yorkie.document.operation.OperationInfo
import kotlinx.coroutines.CoroutineStart
import kotlinx.coroutines.Job
import kotlinx.coroutines.delay
Expand Down Expand Up @@ -108,20 +106,18 @@ class ClientTest {
assertIs<DocumentSyncResult.Synced>(syncEvent.result)

val localSetEvent = assertIs<LocalChange>(document1Events.first())
val localSetOperation = assertIs<SetOperation>(
localSetEvent.changeInfos.first().change.operations.first(),
val localSetOperation = assertIs<OperationInfo.SetOpInfo>(
localSetEvent.changeInfos.first().operations.first(),
)
assertEquals("k1", localSetOperation.key)
assertEquals("v1", (localSetOperation.value as CrdtPrimitive).value)
assertEquals(".k.1", localSetEvent.changeInfos.first().paths.first())
assertEquals("$", localSetEvent.changeInfos.first().operations.first().path)
document1Events.clear()

val remoteSetEvent = assertIs<RemoteChange>(document2Events.first())
val remoteSetOperation = assertIs<SetOperation>(
remoteSetEvent.changeInfos.first().change.operations.first(),
val remoteSetOperation = assertIs<OperationInfo.SetOpInfo>(
remoteSetEvent.changeInfos.first().operations.first(),
)
assertEquals("k1", remoteSetOperation.key)
assertEquals("v1", (remoteSetOperation.value as CrdtPrimitive).value)
document2Events.clear()

val root2 = document2.getRoot()
Expand All @@ -146,16 +142,16 @@ class ClientTest {
assertTrue(root1.keys.isEmpty())

val remoteRemoveEvent = assertIs<RemoteChange>(document1Events.first())
val remoteRemoveOperation = assertIs<RemoveOperation>(
remoteRemoveEvent.changeInfos.first().change.operations.first(),
val remoteRemoveOperation = assertIs<OperationInfo.RemoveOpInfo>(
remoteRemoveEvent.changeInfos.first().operations.first(),
)
assertEquals(localSetOperation.effectedCreatedAt, remoteRemoveOperation.createdAt)
assertEquals(localSetOperation.executedAt, remoteRemoveOperation.executedAt)

val localRemoveEvent = assertIs<LocalChange>(document2Events.first())
val localRemoveOperation = assertIs<RemoveOperation>(
localRemoveEvent.changeInfos.first().change.operations.first(),
val localRemoveOperation = assertIs<OperationInfo.RemoveOpInfo>(
localRemoveEvent.changeInfos.first().operations.first(),
)
assertEquals(remoteSetOperation.effectedCreatedAt, localRemoveOperation.createdAt)
assertEquals(remoteSetOperation.executedAt, localRemoveOperation.executedAt)

assertEquals(1, document1.clone?.getGarbageLength())
assertEquals(1, document2.clone?.getGarbageLength())
Expand Down
Loading