Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent escaping slash of URL #127

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Prevent escaping slash of URL #127

merged 1 commit into from
Nov 8, 2023

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Nov 6, 2023

What this PR does / why we need it:

  • To prevent escaping shahs of URL.
    • eg. (http://abc.def -> http:\/\/abc.def)
    • apply "withoutEscapingSlashes" option when encoding dictionaries to JSON
  • I also made changes to the TCs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4a63cca) 43.02% compared to head (2b0b1ad) 43.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   43.02%   43.02%           
=======================================
  Files         104      104           
  Lines       22932    22932           
=======================================
  Hits         9866     9866           
  Misses      13066    13066           
Files Coverage Δ
Sources/Document/CRDT/CRDTText.swift 88.99% <100.00%> (ø)
Sources/Util/Dictionary+Extension.swift 31.32% <0.00%> (ø)
Tests/Integration/TextIntegrationTests.swift 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@myupage myupage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@humdrum humdrum merged commit 9e11024 into main Nov 8, 2023
3 checks passed
@humdrum humdrum deleted the prevent_esacape_slash branch November 8, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants