Fix the Incorrectly generated attributes for toJsonString of Tree #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The attributes of Tree node are contained as json String.
When initialize the JSONTreeNode, the json String converted to dictionary by toJSONObject in String+Extension.
yorkie-ios-sdk/Sources/Util/String+Extensions.swift
Lines 41 to 47 in ca1fbc0
The "jsonObject" that "JSONSerialization.jsonObject()" creates contains foundation types. (NSNumber, NSString...)
Since "jsonObject" isn't Encodable, they can't converted to string by old logic.
So I added JSONSerialization.data() to convert them to string.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: