Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect interface changes of server DB sharding #145

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Jan 22, 2024

What this PR does / why we need it:
iOS implementation for the corresponding JS PR

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (f1c18b3) 42.69% compared to head (64fd6a9) 42.58%.
Report is 1 commits behind head on main.

Files Patch % Lines
Sources/API/V1/yorkie/v1/yorkie.pb.swift 0.00% 54 Missing ⚠️
Sources/Core/Client.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   42.69%   42.58%   -0.11%     
==========================================
  Files         104      104              
  Lines       24216    24276      +60     
==========================================
  Hits        10338    10338              
- Misses      13878    13938      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@myupage myupage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@humdrum humdrum merged commit b1d58ea into main Jan 25, 2024
3 checks passed
@humdrum humdrum deleted the reflect-interface-changes-due-to-server-db-sharding branch January 25, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants